Skip to content

ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #491)#476

Closed
juliansteenbakker wants to merge 5 commits intofluttercommunity:mainfrom
juliansteenbakker:ci-upgrade-flutter-2
Closed

ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #491)#476
juliansteenbakker wants to merge 5 commits intofluttercommunity:mainfrom
juliansteenbakker:ci-upgrade-flutter-2

Conversation

@juliansteenbakker
Copy link
Copy Markdown
Contributor

@juliansteenbakker juliansteenbakker commented Oct 1, 2021

Description

This will upgrade the CI flutter version to 2.5.2.

Related Issues

This will depend on #466 since it will not pass with the deprecated integration_test.
This is also blocking #442.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ X] All existing and new tests are passing.
  • [X ] I updated/added relevant documentation (doc comments with ///).
  • [X ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ X] I read and followed the Flutter Style Guide.
  • [ X] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@juliansteenbakker juliansteenbakker changed the title ci: upgrade flutter from 2.2.1 to 2.5.2 ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #422) Oct 1, 2021
@juliansteenbakker juliansteenbakker changed the title ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #422) ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #442) Oct 1, 2021
@juliansteenbakker juliansteenbakker changed the title ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #442) ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #466) Oct 1, 2021
@juliansteenbakker
Copy link
Copy Markdown
Contributor Author

juliansteenbakker commented Oct 1, 2021

This is blocked by #466

@mhadaily mhadaily self-requested a review October 1, 2021 14:22
@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 1, 2021
@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

Can you please merge with main that should fix the CI

@juliansteenbakker
Copy link
Copy Markdown
Contributor Author

juliansteenbakker commented Oct 1, 2021

It seems like some tests are failing with latest flutter release. I'll check them and update this PR ASAP.

@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

thanks, I'll review again tomorrow morning.

mhadaily
mhadaily requested changes Oct 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider my comments

Comment thread packages/package_info_plus/package_info_plus_windows/lib/src/file_version_info.dart
Comment thread packages/package_info_plus/package_info_plus_windows/pubspec.yaml Outdated
Comment thread packages/package_info_plus/package_info_plus_windows/CHANGELOG.md Outdated
@juliansteenbakker juliansteenbakker mentioned this pull request Oct 2, 2021
Merged
9 tasks
@juliansteenbakker juliansteenbakker changed the title ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #466) ci: upgrade flutter from 2.2.1 to 2.5.2 (blocked by #491) Oct 2, 2021
@juliansteenbakker
Copy link
Copy Markdown
Contributor Author

juliansteenbakker commented Oct 2, 2021

I have moved the required changes to the windows package into #491

@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 3, 2021

thanks, I have prepared a new PR #489 that covers this. I'll close this PR but will consider your contribution for sure. you have done a great job. thanks

@mhadaily mhadaily closed this Oct 3, 2021
@mhadaily mhadaily mentioned this pull request Nov 19, 2021
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mhadaily mhadaily mhadaily requested changes

Assignees

@juliansteenbakker juliansteenbakker

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliansteenbakker @mhadaily